Feature/wizard #127
Draft
Feature/wizard #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ateska
approved these changes
Jun 23, 2021
Pe5h4
requested changes
Jun 23, 2021
| @@ -1,6 +1,10 @@ | |||
| export default class Module { | |||
| constructor(app, name) { | |||
| this.App = app; | |||
| this.Name = name; | |||
| this.Config = app?.config; | |||
There was a problem hiding this comment.
@titkov49 Why do you need to define Config, Navigation and Router in here? Also, I think it should be without ?. Also, be patient with the indentation on line 6 and 7
| import json from './mock-data.json'; | ||
|
|
||
| const WizardContainer = (props) => { | ||
| console.log(json) |
There was a problem hiding this comment.
@titkov49 Here is some forgotten console.log
| constructor (app) { | ||
| super(app, "WizardModule"); | ||
|
|
||
| console.log("WizardModule: ", this); |
There was a problem hiding this comment.
@titkov49 Here is some forgotten console.log
| @@ -0,0 +1,119 @@ | |||
| { | |||
There was a problem hiding this comment.
@titkov49 Do we need mocked data in the modules/wizard? It might be better, if it would be a part of documentation or better - the public folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to work on asab-webui wizard. Created new module for Wizard