MPL: support for multi pattern snapping #6738
Draft
+243
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: João Mai <[email protected]>
…o mpl-multi-pattern
Signed-off-by: João Mai <[email protected]>
Signed-off-by: João Mai <[email protected]>
Signed-off-by: João Mai <[email protected]>
…o mpl-multi-pattern
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: João Mai <[email protected]>
Signed-off-by: João Mai <[email protected]>
AcKoucher
suggested changes
Feb 24, 2025
Signed-off-by: João Mai <[email protected]>
…o mpl-multi-pattern
Signed-off-by: João Mai <[email protected]>
AcKoucher
suggested changes
Feb 25, 2025
Signed-off-by: João Mai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6360.
This PR refactors the data structures used in snapping to enable snapping to patterns instead of snapping to layers. For most designs, it works in the same way.
The snapping logic is the same still, snapping to layers with multiple patterns simply assigns a pin to each pattern and tries to snap to the pattern. The pin is assigned by searching for a pair of pins that follow the pattern in question, as snapping to one of them means all pins in the same pattern are snapped.