Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsz: use the swappable cells cache added in #6762. #6790

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mikesinouye
Copy link
Contributor

@mikesinouye mikesinouye commented Feb 27, 2025

This actually uses the cache. I had inadvertently omitted this part of the change when creating the PR. Thanks for catching that @povik.

I also added clearing of the cache in Resizer::init() so that we respect changes to the recently added opt configs.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@precisionmoon precisionmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resizer::init() is inside a preamble for many resizer functions like repair_design, repair_timing and buffer_inputs/ibuffer_outputs. Do we want to reset the cache in Resizer::init(Logger* logger, dbDatabase* db, dbSta* sta, ....) instead?

@mikesinouye
Copy link
Contributor Author

Resizer::init() is inside a preamble for many resizer functions like repair_design, repair_timing and buffer_inputs/ibuffer_outputs. Do we want to reset the cache in Resizer::init(Logger* logger, dbDatabase* db, dbSta* sta, ....) instead?

The main issue is that the equivalent cache is invalidated each time one of the various set_opt_configs such as limit_sizing_area is set. Currently, these settings are re-applied in each call to Resizer::initBlock(), not when they are actually set in TCL. Therefore it seemed I had to reset the cache for each call to the resizer. We still get the majority of the performance uplift by doing so.

If we could relocate the updating of the opt configs to when they are updated, then I think we could clear the cache right after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants