-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsz: use the swappable cells cache added in #6762. #6790
base: master
Are you sure you want to change the base?
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Mike Inouye <[email protected]>
Signed-off-by: Mike Inouye <[email protected]>
Signed-off-by: Mike Inouye <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resizer::init() is inside a preamble for many resizer functions like repair_design, repair_timing and buffer_inputs/ibuffer_outputs. Do we want to reset the cache in Resizer::init(Logger* logger, dbDatabase* db, dbSta* sta, ....) instead?
The main issue is that the equivalent cache is invalidated each time one of the various If we could relocate the updating of the opt configs to when they are updated, then I think we could clear the cache right after. |
This actually uses the cache. I had inadvertently omitted this part of the change when creating the PR. Thanks for catching that @povik.
I also added clearing of the cache in Resizer::init() so that we respect changes to the recently added opt configs.