drt: unique_inst_patterns_ structure structure refactor #6796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -50,6 +50,9 @@ class frInst : public frRef | |||
| : name_(name), master_(master), db_inst_(db_inst) | |||
| { | |||
| } | |||
| // used for archive serialization | |||
| frInst() : name_(""), master_(nullptr), db_inst_(nullptr) {} | |||
There was a problem hiding this comment.
warning: redundant string initialization [readability-redundant-string-init]
Suggested change
| frInst() : name_(""), master_(nullptr), db_inst_(nullptr) {} | |
| frInst() : , master_(nullptr), db_inst_(nullptr) {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #5867.
Branched of #6778.
ISPD and Secure CI associated, will be opened once safe.
unique_inst_patterns_structure change.One of the requirements of incremental PA is for the used structures to be dynamic. Once a complete run of PA is done, it is necessary to run it again for a set of instances while keeping data of unaltered instances. While #6778 introduces a function to allow for solving the access patterns of a single unique instance, the
unique_inst_patterns_does not allow for new entries to be inserted. The structure used to be a vector of fixed sized, which made the managing of new entries very difficult. In that light the structure was changed to an unordered map, in which the unique instance pointer acts as a key. This allows for inserting and deleting entries without major disruptions of the whole structure.Related minor changes.
FlexPA.hnow includes#include <boost/serialization/unordered_map.hpp>to support the unordered map serialization.FrInst()now has an empty default constructor, also required for serialization.UniqueInstsnow has a function to retrieve the unique instance related to the instance.unique_inst_patterns_are protected by#pragma omp criticalto avoid race conditions.