Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: add save histogram image #6825

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gadfort
Copy link
Collaborator

@gadfort gadfort commented Mar 8, 2025

Changes:

  • reorganized the ChartsWidget to ensure the histogramwidget owns all the display data to allow for easier integration with the save image code.
  • added a save option to the mouse menu
  • added access from tcl to save the image via save_histogram_image
  • added hold timing to to bar chart

@gadfort gadfort requested a review from maliberty March 8, 2025 15:41
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Signed-off-by: Peter Gadfort <[email protected]>
@maliberty
Copy link
Member

The default size is quite small and when zoomed in shows the labels don't fit

image

@gadfort
Copy link
Collaborator Author

gadfort commented Mar 9, 2025

@maliberty the default just takes the size of the widget from the GUI, I can update it enforce the height is == width when not specified. (unfortunately this size if dependent on the state of your gui, so it's a bit difficult to replicate). This mirrors the behavior of the clock widget, but maybe it's better to select a default like (500x500 or 1000x1000) which tend to generate reasonable images (and then ignore the widget size altogether).

@maliberty
Copy link
Member

Thanks. It works fine aside from the default size. I think have some constant like you suggest is best.

@maliberty maliberty enabled auto-merge March 9, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants