List.List' is deprecated:Fixed #191 for tim_sort.dart #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skdotv
changed the title
skdotv
changed the title
akashgk
requested changes
Oct 26, 2022
| @@ -15,7 +15,7 @@ void insertionSort(List list, int left, int right) { | |||
|
|
|||
| void merge(List list, int left, int middle, int right) { | |||
| int length1 = middle - left + 1, length2 = right - middle; | |||
| List leftList = new List(length1), rightList = new List(length2); | |||
| List leftList = []..length = length1, rightList = []..length = length2; | |||
There was a problem hiding this comment.
I think assigning length value is not a good practice. Can we change the constructor to List.filled()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Dart community
Describe your change:
List.List' is deprecated: Fixed
Checklist:
Fixes: #{$ISSUE_NO}.