-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue Closed #218 Create Lanczos_approximation #223
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments left. Please address them
} else { | ||
return -factorial(n); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add main function with tests.
} else { | ||
return -factorial(n); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove EOF,
run dart format
on this file.
const List<double> p = [ | ||
676.5203681218851, -1259.1392167224028, 771.32342877765313, | ||
-176.61502916214059, 12.507343278686905, -0.13857109526572012, | ||
9.9843695780195716e-6, 1.5056327351493116e-7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use descriptive variable names
@@ -0,0 +1,35 @@ | |||
import 'dart:math'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add url to lanczos approximation
Welcome to Dart community
Describe your change:
Checklist:
Fixes: #218
.