Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Closed #218 Create Lanczos_approximation #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Preetiraj3697
Copy link

@Preetiraj3697 Preetiraj3697 commented Apr 19, 2023

Welcome to Dart community

Describe your change:

  • Add an algorithm? ans. Lanczos_approximation
  • Fix a bug or typo in an existing algorithm? ans. Bug in factorial calculation Bug in factorial calculation #218
  • Documentation change?
  • Add/Update/Fix test cases.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Dart files are placed inside an existing directory.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #218 .

Copy link
Member

@akashgk akashgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments left. Please address them

} else {
return -factorial(n);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add main function with tests.

} else {
return -factorial(n);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove EOF,

run dart format on this file.

Comment on lines +10 to +13
const List<double> p = [
676.5203681218851, -1259.1392167224028, 771.32342877765313,
-176.61502916214059, 12.507343278686905, -0.13857109526572012,
9.9843695780195716e-6, 1.5056327351493116e-7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use descriptive variable names

@@ -0,0 +1,35 @@
import 'dart:math';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add url to lanczos approximation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants