Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove URL validation #1335

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Remove URL validation #1335

merged 4 commits into from
Jul 14, 2023

Conversation

0-harshit-0
Copy link
Contributor

Fixes: #1183
Used JS URL API to check if URL is valid. If valid it will return the url else false;

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • [ ✔️ ] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ ✔️ ] I have read CONTRIBUTING.md.
  • [ ✔️ ] This pull request is all my own work -- I have not plagiarized.
  • [ ✔️ ] I know that pull requests will not be merged if they fail the automated tests.
  • [ ✔️ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ✔️ ] All new JavaScript files are placed inside an existing directory.
  • [ ✔️ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ ✔️ ] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ✔️ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Used JS URL API to check if URL is valid. If valid it will return the url else false;
fixed code style test.
Fixed for #1183
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this; it has about zero educational value (except for in a way "documenting" that the URL constructor throws an error on invalid URLs).

Effectively this is just a wrapper for the URL constructor, "coercing" errors into a boolean false. This adds no real value over the URL constructor and removes educational value by removing the (arguably broken) RegEx.

I see the following two options:

  • Remove ValidateURL, since it is obviously broken.
  • Fix ValidateURL, reimplementing JavaScript builtin functionality (to demonstrate how it might be implemented).

@0-harshit-0
Copy link
Contributor Author

ok got it.

@0-harshit-0
Copy link
Contributor Author

hello, I have removed the function.

@appgurueu appgurueu changed the title Update ValidateUrl.js Remove URL validation Jul 14, 2023
@raklaptudirm raklaptudirm merged commit ecac786 into TheAlgorithms:master Jul 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate Url Issues
3 participants