Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore / Spike: Upgrade app to rails 7.2 #4743

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChargrilledChook
Copy link
Member

@ChargrilledChook ChargrilledChook commented Aug 11, 2024

Quick spike to test effort of ugprading to Rails 7.2, as there aren't many huge changes.

Findings: low effort.

Notes:

  • Linters failing in CI but not locally via bin/test, likely because CI uses rubocop binstub and new config adds an explicit .rubocop.yml load
  • Defaults recommend changing the default max thread count from 5 to 3
  • Check if YJIT is in the Docker image we use
  • Some ActiveJob weirdness in console when running app locally, but could just be janky state in local env.
  • Several Rails 8 deprecations notices being spammed, particularly for enums - see change here

This commit:

  • Update version in Gemfile
  • Run bundle update
  • Run app:update task
  • Fix broken specs
  • Toggle new framework defaults

This commit:
  * Update version in Gemfile
  * Run bundle update
  * Run `app:update` task
  * Fix broken specs
  * Toggle new framework defaults
@ChargrilledChook ChargrilledChook changed the title Chore: Upgrade app to rails 7.2 Chore / Spike: Upgrade app to rails 7.2 Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog / Ideas
Development

Successfully merging this pull request may close these issues.

1 participant