Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 1028 #1088

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Dev 1028 #1088

merged 2 commits into from
Aug 9, 2023

Conversation

VincentGuyader
Copy link
Member

@ilyaZar I made some modifications :)

ilyaZar and others added 2 commits August 9, 2023 14:59
* refactor: add helper for installation of a single dev dep

- choose a good installer for "sass" following the style of install_dev_deps()
- fix minor typo inside doc of install_dev_deps()

* fix: fix the bug at "sass::" line of dev/run_dev.R

- check if dev/run_dev.R has a "sass"-line a-la "sass::"
- use the installer install_single_dev_dep() to install SASS

The user is usually asked as force_install=FALSE. Can be changed internally later so pak::pak or install.packages is used in interactive mode (or the behaviour from install_dev_deps if non-interactive).
add httpuv in dev_deps
add dev_deps parameters in install_dev_deps to allow specific deps installation
use attachment::att_from_rscript to detect run_dev.R dependencies
@VincentGuyader VincentGuyader changed the base branch from master to dev August 9, 2023 14:37
@ilyaZar
Copy link
Contributor

ilyaZar commented Aug 9, 2023

sure thanks for merging !

@VincentGuyader VincentGuyader merged commit 1971f72 into dev Aug 9, 2023
6 checks passed
@ColinFay ColinFay deleted the dev_1028 branch February 28, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants