Update pubsub.go #306
Open
Update pubsub.go #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no subscriber should return an error when publishing
fix mod name
m110
reviewed
Jan 2, 2023
| @@ -1,4 +1,4 @@ | |||
| module github.com/ThreeDotsLabs/watermill | |||
| module github.com/golang-boy/watermill | |||
There was a problem hiding this comment.
Suggested change
| module github.com/golang-boy/watermill | |
| module github.com/ThreeDotsLabs/watermill |
m110
reviewed
Jan 2, 2023
Comment on lines
+145
to
+147
| err := errors.New("No subscribers") | ||
| g.logger.Error("No subscribers to send message", err, logFields) | ||
| return ackedBySubscribers, err |
There was a problem hiding this comment.
There's no error by design, as Publish drops the message if no subscribers are waiting for it. If you'd like to see an error in this case, we would need a configuration option not to change the current behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no subscriber should return an error when publishing