Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #2162

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Fix failing tests #2162

merged 3 commits into from
Feb 14, 2025

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Feb 14, 2025

We currently have two failing tests:

Daily tests run: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/13333400928

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but can you please add some information for future reference about why these fix the errors?

Changed to our own assertion function

Why? (Was this the source of the aborts we saw with numpy 1?)

test_dask_multiattr_2d - ModuleNotFoundError: No module named 'distributed'

Marking as flaky is fine, but should be unrelated to the No module error, right?

@kounelisagis
Copy link
Member Author

Seems fine, but can you please add some information for future reference about why these fix the errors?

Changed to our own assertion function

Why? (Was this the source of the aborts we saw with numpy 1?)

test_dask_multiattr_2d - ModuleNotFoundError: No module named 'distributed'

Marking as flaky is fine, but should be unrelated to the No module error, right?

Description edited.

@kounelisagis kounelisagis merged commit 3bafb00 into main Feb 14, 2025
43 checks passed
@kounelisagis kounelisagis deleted the agis/fix-tests branch February 14, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants