Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an additional C API example "aggregates_string" which demonstrates running min/max on string dimension and emitting coordinates from the same query #5302
base: dev
Are you sure you want to change the base?
Add an additional C API example "aggregates_string" which demonstrates running min/max on string dimension and emitting coordinates from the same query #5302
Changes from 4 commits
cacc177
cf3f776
ca6a862
1eb8123
b230180
2f4f24f
efd5b06
d110916
a8e7e2e
d90478a
32d6dad
72a750e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of
min_offsets
? SinceMin(rows)
is an aggregate it will have only one value and its size can be obtained throughmin_size
set above, but I'm seeingmin_offsets[0]
being used below; shouldn't it always be zero?If the Core requires an offsets buffer for a variable-sized aggregate field to be set, that should be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, the offsets will always be written as a single array whose contents are zero.
The offsets buffer is required.
Both of these aspects are also true if you were to query a single variable-length cell; while I agree that there's no data to be communicated, it has the same structure as existing code. So I'm not sure I agree with you that anything is worth changing here.