-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: finalize clickhouse engine adapter #3125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
reviewed
Sep 13, 2024
erindru
reviewed
Sep 13, 2024
erindru
reviewed
Sep 13, 2024
Awesome work! I bet you learned way more than you wanted to about the Clickhouse internals |
treysp
force-pushed
the
trey/improve-ch-adapter
branch
from
September 13, 2024 14:33
03be872
to
85da392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @treysp!
treysp
force-pushed
the
trey/improve-ch-adapter
branch
from
September 16, 2024 14:52
85da392
to
5e28b8a
Compare
izeigerman
reviewed
Sep 16, 2024
izeigerman
reviewed
Sep 16, 2024
izeigerman
reviewed
Sep 16, 2024
izeigerman
reviewed
Sep 16, 2024
izeigerman
reviewed
Sep 16, 2024
izeigerman
reviewed
Sep 16, 2024
izeigerman
reviewed
Sep 16, 2024
treysp
force-pushed
the
trey/improve-ch-adapter
branch
4 times, most recently
from
September 17, 2024 19:47
626240e
to
8f1636d
Compare
treysp
force-pushed
the
trey/improve-ch-adapter
branch
2 times, most recently
from
September 18, 2024 14:53
6d9243f
to
dfa9b97
Compare
izeigerman
reviewed
Sep 18, 2024
izeigerman
approved these changes
Sep 18, 2024
treysp
force-pushed
the
trey/improve-ch-adapter
branch
from
September 18, 2024 21:42
dfa9b97
to
3ee23cd
Compare
treysp
changed the title
Feat!: finalize clickhouse engine adapter
Feat: finalize clickhouse engine adapter
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalizes the Clickhouse engine adapter:
Context and implementation details
Joins and NULLs
SETTINGS join_use_nulls = 1
into the queryjoin_use_nulls
= 0 on the CH server, we injectjoin_use_nulls = 0
into the CTE to preserve behavior expected by user.Connection settings
Storage format
MergeTree
by default)storage_format
key