Code

Collapse nodes on any terminal status#2

Code

Closed

Tom-Newton wants to merge 19 commits intomasterTom-Newton/flyte:masterfrom tomnewton/collapse_sub_nodes_on_failuresTom-Newton/flyte:tomnewton/collapse_sub_nodes_on_failuresCopy head branch name to clipboard

+269-189

Commits

Commits on Dec 13, 2023

• ClearSubNodeStatus on failure

  Show description for b4c58be
  Tom-Newton

  committed
  b4c58be

  Copy full SHA for b4c58be

• More aggressive collapsing

  Show description for a4569be
  Tom-Newton

  committed
  a4569be

  Copy full SHA for a4569be

• Tidy

  Show description for eccf702
  Tom-Newton

  committed
  eccf702

  Copy full SHA for eccf702

• Fix panic

  Show description for dd6cd7b
  Tom-Newton

  committed
  dd6cd7b

  Copy full SHA for dd6cd7b

• Tidy

  Show description for 8e0f748
  Tom-Newton

  committed
  8e0f748

  Copy full SHA for 8e0f748

• Handle possibility of nil startedAt time

  Show description for 2fc33e7
  Tom-Newton

  committed
  2fc33e7

  Copy full SHA for 2fc33e7

• Update test assertions

  Show description for fb549c4
  Tom-Newton

  committed
  fb549c4

  Copy full SHA for fb549c4

• Config flag attempt 1

  Show description for def9c50
  Tom-Newton

  committed
  def9c50

  Copy full SHA for def9c50

• Update more calls to UpdatePhase

  Show description for a285f72
  Tom-Newton

  committed
  a285f72

  Copy full SHA for a285f72

• Update generated code

  Show description for e475a78
  Tom-Newton

  committed
  e475a78

  Copy full SHA for e475a78

• Update tests

  Show description for 09786cb
  Tom-Newton

  committed
  09786cb

  Copy full SHA for 09786cb

• Fix more tests

  Show description for 2c0b4d4
  Tom-Newton

  committed
  2c0b4d4

  Copy full SHA for 2c0b4d4

• Fix tests

  Show description for 6cc9a9d
  Tom-Newton

  committed
  6cc9a9d

  Copy full SHA for 6cc9a9d

• Rename clear-state-on-termination -> clear-state-on-any-termination

  Show description for 2efb329
  Tom-Newton

  committed
  2efb329

  Copy full SHA for 2efb329

• Add a comment

  Show description for 625ab3d
  Tom-Newton

  committed
  625ab3d

  Copy full SHA for 625ab3d

Commits on Dec 14, 2023

• Missing test coverage - add test case non-terminal-timing-out

  Show description for 42fb049
  Tom-Newton

  committed
  42fb049

  Copy full SHA for 42fb049

Commits on Dec 15, 2023

• Add test coverage for TestNodeExecutor_RecursiveNodeHandler_Recurse with clearStateOnAnyTermination=true

  Show description for f3d9f7b
  Tom-Newton

  committed
  f3d9f7b

  Copy full SHA for f3d9f7b

• Address another TODO

  Show description for 453a69f
  Tom-Newton

  committed
  453a69f

  Copy full SHA for 453a69f

• Add comment

  Show description for fb9bd90
  Tom-Newton

  committed
  fb9bd90

  Copy full SHA for fb9bd90