The most significant changes involve the modification of the renaming… #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method in the `CTkTabview` class and the addition of code to update the `_current_name` attribute. These changes ensure that the tab renaming process is more efficient and that the connection to the frame is maintained even when a tab is renamed. Changes: 1. The renaming method in the `CTkTabview` class has been altered. Instead of removing the old name from the `_name_list` and appending the new name at the end, the new name now replaces the old name at the same index in the `_name_list`. This change makes the renaming process more efficient. 2. Code has been added to update the `_current_name` attribute if the old name matches the current name. This is a crucial change as it ensures that the connection to the frame is not lost when a tab is renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… method in the
CTkTabviewclass and the addition of code to update the_current_nameattribute. These changes ensure that the tab renaming process is more efficient and that the connection to the frame is maintained even when a tab is renamed.Changes:
CTkTabviewclass has been altered. Instead of removing the old name from the_name_listand appending the new name at the end, the new name now replaces the old name at the same index in the_name_list. This change makes the renaming process more efficient._current_nameattribute if the old name matches the current name. This is a crucial change as it ensures that the connection to the frame is not lost when a tab is renamed.