Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api/kd02109 #64

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Api/kd02109 #64

wants to merge 12 commits into from

Conversation

kd02109
Copy link
Contributor

@kd02109 kd02109 commented Mar 27, 2024

What is this PR?

  • 로그인 api 연결을 마무리 했습니다.
  • Next 서버 단에서 fetch 요청이 필요한 경우 cookie 값을 별도로 세팅해야 하기 때문에, 별도의 serverUtil을 만들었습니다.
  • credential 옵션을 잘못 설정한 것을 수정했습니다.
  • checkoption 에서 verification body 값의 오타를 수정했습니다.

What has changed?


A notice to reviewers...


Screen

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swifty-frontend-swifty-bank ❌ Failed (Inspect) Mar 27, 2024 6:42am

Copy link
Contributor

@DoctorK4 DoctorK4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

keypadToken: string;
}>(URL.USER.keypad, {}, "no-store");
}>(URL.USER.keypad, {}, "force-cache");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force-cache로 변경하신 이유가 궁금합니다. 제가 처음에 세팅했을 때의 의도는, 보안상 키패드는 캐싱없이 새로 받아와야할 것같아서 no-store로 했었습니다.

setValue(uniqueResiter, !isCheck, { shouldValidate: true });
}
};
const onChage = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const onChage = () => {
const onChange = () => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants