Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EWT-636] Upgrade to net8 #327

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/csharp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,10 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-dotnet@v4
with:
dotnet-version: '5.0.x'
dotnet-version: '8.0.x'
- uses: actions/setup-dotnet@v4
with:
dotnet-version: '3.1.x'
- uses: actions/setup-dotnet@v4
with:
dotnet-version: '2.2.x'
- run: cd csharp && dotnet build && dotnet test

examples:
Expand All @@ -38,7 +35,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-dotnet@v4
with:
dotnet-version: '6.0.x'
dotnet-version: '8.0.x'
- run: cd csharp/examples/webhook-server && dotnet build
- run: cd csharp/examples/sign-request && dotnet build

Expand All @@ -52,7 +49,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x
- name: Generate NuGet package
run: |
cd csharp
Expand Down
12 changes: 6 additions & 6 deletions csharp/src/truelayer-signing.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<PackageVersion>0.1.15</PackageVersion>
<TargetFrameworks>net5.0;netstandard2.0;netstandard2.1</TargetFrameworks>
<PackageVersion>0.2.0</PackageVersion>
<TargetFrameworks>net8.0;netstandard2.0;netstandard2.1</TargetFrameworks>
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
<Nullable>enable</Nullable>
<LangVersion>9</LangVersion>
Expand All @@ -25,13 +25,13 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="jose-jwt" Version="3.2.0" />
<PackageReference Include="jose-jwt" Version="5.1.0" />
<!-- Resolves: Found conflicts between different versions of "System.Text.Encodings.Web" -->
<PackageReference Include="System.Text.Encodings.Web" Version="5.0.1" />
<PackageReference Include="System.Text.Encodings.Web" Version="8.0.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<PackageReference Include="System.Text.Json" Version="5.0.1" />
<PackageReference Include="Portable.BouncyCastle" Version="1.8.1.2" />
<PackageReference Include="System.Text.Json" Version="5.0.2" />
<PackageReference Include="Portable.BouncyCastle" Version="1.9.0" />
</ItemGroup>

<ItemGroup>
Expand Down
14 changes: 8 additions & 6 deletions csharp/test/truelayer-signing.test.csproj
Original file line number Diff line number Diff line change
@@ -1,19 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>netcoreapp2.2;netcoreapp3.1;net5.0</TargetFrameworks>
<TargetFrameworks>net8.0;net6.0;netcoreapp3.1</TargetFrameworks>
<Nullable>enable</Nullable>
<LangVersion>8</LangVersion>
<WarningsAsErrors>CS8600;CS8602;CS8603;CS8604;CS8618</WarningsAsErrors>
<NoWarn>IDE0055</NoWarn>
<IsPackable>false</IsPackable>
<AssemblyName>TrueLayer.Signing.Tests</AssemblyName>
<RootNamespace>TrueLayer.Signing.Tests</RootNamespace>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
<PackageReference Include="FluentAssertions" Version="6.2.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="FluentAssertions" Version="6.12.2" />
<ProjectReference Include="..\src\truelayer-signing.csproj" />
</ItemGroup>
<ItemGroup>
Expand Down
Loading