Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Sodo search translation helper added, strings wrapped, ready for translator work! #21055

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cathysarisky
Copy link
Contributor

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

Translation (t) helper added to sodo-search.
Ghost head tweaked to include data-locale.
All (I hope) strings in sodo-search wrapped in the t helper.

Possibly poor-quality French translation strings added.

@cathysarisky
Copy link
Contributor Author

OK, so it won't quite pass automated tests, because the snapshot needs to be updated to include a locale in this line:
<script defer src=\\"https://cdn.jsdelivr.net/ghost/sodo-search@~[[VERSION]]/umd/sodo-search.min.js\\" data-key=\\"xyz\\" data-styles=\\"https://cdn.jsdelivr.net/ghost/sodo-search@~[[VERSION]]/umd/main.css\\" data-sodo-search=\\"http://localhost:65530/site/\\" crossorigin=\\"anonymous\\"></script>

I don't know enough about Ghost's testing setup to know whether I'm supposed to edit the snapshot file directly, or if there's a command that generates those, so I'm going to leave it alone and hope someone will help me out here! :)

@vikaspotluri123
Copy link
Member

If you run UPDATE_SNAPSHOT=1 yarn test that should update your snapshots!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants