Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/cdd 2182 integrate with cms pagination #586

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feat/cdd 2182 integrate with cms pagination #586

wants to merge 7 commits into from

Conversation

Temiakinsoto
Copy link
Contributor

@Temiakinsoto Temiakinsoto commented Feb 3, 2025 •
edited
Loading

Description

This PR adds feature for toggling pagination component visibility with the "Show pagination" checkbox (cms), and also limits child pages shown based on "Pagination size."

Fixes #CDD-2182

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Temiakinsoto
Add show_pagination and pagination_size:
d131bc9 
This commit adds a show-pagination flag and takes a
pagination-size value from the CMS. The show-pagination
flag is used to hide/display the pagination component.
The pagination-size is used to set the amount of items per page
When show pagination is set to false, all items are displayed at once on the page."
@Temiakinsoto
Add condition for title when all metrics are displayed
2e91b53
@Temiakinsoto
add optional showPagination flag and paginationSize to getMetricsPage…
c0601e1 
…s() function.
@Temiakinsoto
comment failing test for getting metrics documentation metadata
a6fc066
@Temiakinsoto Temiakinsoto marked this pull request as ready for review February 5, 2025 09:18
@Temiakinsoto Temiakinsoto requested a review from a team as a code owner February 5, 2025 09:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Unit tests coverage

Lines Statements Branches Functions
Coverage: 95%
 94.29% (1901/2016) 84.49% (485/574) 94.46% (307/325)
Tests Skipped Failures Errors Time
555 0 💤 0 ❌ 0 🔥 16.104s ⏱️

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Temiakinsoto