Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cdd 2285 - Addition of About Tab and dropdown functionality on mobile #588

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Feature/cdd 2285 - Addition of About Tab and dropdown functionality on mobile #588

wants to merge 28 commits into from

Conversation

luketowell
Copy link
Contributor

Description

This change moves the chart description from the header into a newly created About tab. It also includes manipulating the tabs depending on screen resolution to ensure that drop-downs are displayed on smaller devices so that mobile users can easily navigate between content.

Fixes #CDD-2285

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@luketowell luketowell requested a review from a team as a code owner February 4, 2025 10:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Unit tests coverage

Lines Statements Branches Functions
Coverage: 96%
 94.67% (1973/2084) 84.89% (489/576) 94.73% (324/342)
Tests Skipped Failures Errors Time
570 0 💤 0 ❌ 0 🔥 17.676s ⏱️

@luketowell luketowell force-pushed the feature/CDD-2285 branch 4 times, most recently from fbb71d4 to 0fef2bb Compare February 4, 2025 17:25
@luketowell luketowell force-pushed the feature/CDD-2285 branch 2 times, most recently from db773d0 to 27db6f1 Compare February 5, 2025 09:55
@luketowell
feature/CDD-2285: updated the desktop tests to use desktop and tablet…
22001e1 
… functionality, new test required for mobile dropdown
@luketowell luketowell changed the title Feature/cdd 2285 Feature/cdd 2285 - Addition of About Tab and dropdown functionality on mobile Feb 12, 2025
@8lane
Copy link
Collaborator

8lane commented Feb 12, 2025

image

Some responsive issues

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
27.2% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8lane 8lane 8lane approved these changes

@rhys-burendo rhys-burendo rhys-burendo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luketowell @8lane @rhys-burendo