fix default player colors, we should not reference I outside the loop #959
+4
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problematic lines were referencing
I
outside the loop. I assume this gets compiled differently on different platforms, because it never triggered for me (Linux). To reproduce I had to hardcode the deleted lines to read fromP12
.Either way, I've made the default colors an array of numbers that just happen to be in the desired order. Downside is it's one more thing to change if we ever increase
IMaxPlayerCount
but that's not happening soon anyway. And at least I put the array directly below it,I will tag some people to test this once the artifacts are built, because I cannot verify if this fixes it for them as well.
fixes #958