Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default player colors, we should not reference I outside the loop #959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barbeque-squared
Copy link
Member

The problematic lines were referencing I outside the loop. I assume this gets compiled differently on different platforms, because it never triggered for me (Linux). To reproduce I had to hardcode the deleted lines to read from P12.

Either way, I've made the default colors an array of numbers that just happen to be in the desired order. Downside is it's one more thing to change if we ever increase IMaxPlayerCount but that's not happening soon anyway. And at least I put the array directly below it,

I will tag some people to test this once the artifacts are built, because I cannot verify if this fixes it for them as well.

fixes #958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Color Player 2 ignored
1 participant