Add cli argument --rpc-allow-fallback-to-random-port
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when Substrate node is starting it binds to configured JSON-RPC HTTP port and WS port. If this port is already in use then it binds to a random port instead. Sometimes this behavior creates problems. For example during development if a developer for some reason forgets to stop an old version of a node and starts a new version then all tests will run against the old version. Such an issue could be hard to diagnose.
This PR fixes the issue by making this behavior configurable and adding cli argument
--rpc-allow-fallback-to-random-port
. By default if the argument isn't used or if--rpc-allow-fallback-to-random-port=true
is added then node behaves as before. But if--rpc-allow-fallback-to-random-port=false
is added then a node will panic instead of binding to random port withAddress is already in use
error.