Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove native transfer gas limit #189

Merged
merged 1 commit into from
Aug 21, 2023
Merged

feat: remove native transfer gas limit #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-DutchOrder-BaseExecuteSingleWithFee.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
150417
181978
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-DutchOrder-ExecuteBatchNativeOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
190447
190411
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-DutchOrder-ExecuteSingleNativeOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
133774
133756
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-DutchOrder-ExecuteSingleValidation.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
157505
137605
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-ExclusiveDutchOrder-BaseExecuteSingleWithFee.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
182186
150633
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-ExclusiveDutchOrder-ExecuteBatchNativeOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
190845
190809
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-ExclusiveDutchOrder-ExecuteSingleNativeOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
133986
95568
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-LimitOrderReactor-BaseExecuteSingleWithFee.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
146554
178116
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-LimitOrderReactor-ExecuteBatchNativeOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
182618
182582
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-LimitOrderReactor-ExecuteSingle.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
124433
144333
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-LimitOrderReactor-ExecuteSingleNativeOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
129913
129895
2 changes: 1 addition & 1 deletion .forge-snapshots/Base-LimitOrderReactor-ExecuteSingleValidation.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
153643
133743
2 changes: 1 addition & 1 deletion .forge-snapshots/DirectFillerFillMacroTestEth1Output.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
147399
147390
2 changes: 1 addition & 1 deletion .forge-snapshots/DirectFillerFillMacroTestEth2Outputs.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
170622
170604
2 changes: 1 addition & 1 deletion .forge-snapshots/EthOutputTest3OrdersWithEthAndERC20Outputs.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
363514
363478
2 changes: 1 addition & 1 deletion .forge-snapshots/EthOutputTestEthOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
156241
156223
2 changes: 1 addition & 1 deletion .forge-snapshots/ProtocolFeesGasComparisonTest-InterfaceAndProtocolFeeEthOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
162961
162907
2 changes: 1 addition & 1 deletion .forge-snapshots/ProtocolFeesGasComparisonTest-InterfaceFeeEthOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
146909
146873
2 changes: 1 addition & 1 deletion .forge-snapshots/ProtocolFeesGasComparisonTest-NoFeesEthOutput.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
124947
124929
3 changes: 1 addition & 2 deletions src/lib/CurrencyLibrary.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {SafeCast} from "openzeppelin-contracts/utils/math/SafeCast.sol";
import {SafeTransferLib} from "solmate/src/utils/SafeTransferLib.sol";

address constant NATIVE = 0x0000000000000000000000000000000000000000;
uint256 constant TRANSFER_NATIVE_GAS_LIMIT = 6900;

/// @title CurrencyLibrary
/// @dev This library allows for transferring native ETH and ERC20s via direct filler OR fill contract.
Expand Down Expand Up @@ -48,7 +47,7 @@ library CurrencyLibrary {
/// @param recipient The recipient of the currency
/// @param amount The amount of currency to transfer
function transferNative(address recipient, uint256 amount) internal {
(bool success,) = recipient.call{value: amount, gas: TRANSFER_NATIVE_GAS_LIMIT}("");
(bool success,) = recipient.call{value: amount}("");
if (!success) revert NativeTransferFailed();
}

Expand Down