Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BaseGoerli #282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support BaseGoerli #282

wants to merge 1 commit into from

Conversation

mikeki
Copy link
Contributor

@mikeki mikeki commented Aug 14, 2023

No description provided.

@jsy1218
Copy link
Member

jsy1218 commented Aug 14, 2023

It felt like when we were rushing to support BASE, couple places were only coded to support BASE, but not BASE_GOERLI, including this repo and in smart-order-router.

I wonder if we first add BASE_GOERLI into SUPPORTED_CHAINS, and see if it can pass the smart-order-router github actions integration tests? (integration tests should automatically add the BASE_GOERLI into the test case, although we might need to add JSON URL into the repo secret)

@jsy1218
Copy link
Member

jsy1218 commented Aug 17, 2023

I tried a bit from https://github.com/Uniswap/smart-order-router side. It appears BASE_GOERLI doesn't have the liquidity for the WETH/USDbC pools yet, so router side cannot be supported yet. Since it's testnet, we might be able to provide liquidities ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants