chore: bump sor to 4.19.0 - feat: tenderly sim status TRANSFER_FROM_FAILED #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (02/28/25)1 assignee was added and 3 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation. |
cgkol
approved these changes
Feb 28, 2025
Merge activity
|
jsy1218
deleted the
siyujiang/sor-4.19.0-tenderly-sim-TRANSFER_FROM_FAILED
branch
jsy1218
added a commit
to Uniswap/routing-api
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
top swap+add: MVP of swap+add endpoint without iterative search #1 reason for sim error from trading-api is due to the transfer from failed. we want to surface this from routing.
What is the new behavior (if this is a feature change)?
transfer_from_failed will be exposed to trading-api.
Other information:
not actionable on the FE though.