-
Notifications
You must be signed in to change notification settings - Fork 167
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #561 from Unity-Technologies/staging
0.3 Staging -> Master
- Loading branch information
Showing
258 changed files
with
17,177 additions
and
13,510 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,27 @@ | ||
### Purpose of this PR | ||
|
||
[Desc of feature/change. Links to screenshots, design docs, user docs, etc. Remember reviewers may be outside your team, and not know your feature/area that should be explained more.] | ||
[Description of the feature/changes. Links to screenshots, design docs, user docs, etc. as necessary. Consider which reviewers may be outside of your team and how much of the feature/area should be explained more.] | ||
|
||
### Testing status | ||
|
||
[Explanation of what’s tested, how tested and existing or new automation tests. Can include manual testing by self and/or QA. Specify test plans. Rarely acceptable to have no testing.] | ||
[Explanation of what’s been tested, how it was tested, and changes to existing or new automation tests. Testing can include manual testing by self and/or QA. Specify test plans; Rarely acceptable to have no testing.] | ||
|
||
### Technical risk | ||
### Technical / Halo risk | ||
|
||
[Overall product level assessment of risk of change. Need technical risk & halo effect.] | ||
[Overall product level assessment of the risk of the changes using the following criteria: | ||
|
||
Tech Risk (not Tech Correctness, which is deferred to the reviewers) | ||
* **0** could be just zero impact changes, removals but no logic changes | ||
* **1** low impact, simple logic changes | ||
* **2** is anything between 1 and 3 | ||
* **3** are extremely likely to introduce bugs | ||
|
||
Halo Risk (Externality risk) | ||
* **0** local change with no risk to other areas | ||
* **1** neighbors could be affected | ||
* **2** anything between 1 and 3 | ||
* **3** things might break everywhere] | ||
|
||
### Comments to reviewers | ||
|
||
[Info per person for what to focus on, or historical info to understand who have previously reviewed and coverage. Help them get context.] | ||
[Per person info for what to focus on or historical info for a new reviewer to understand who may have previously reviewed and what their coverage was. Provide context.] |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.