Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make start_ursim.sh support polyscopex #294

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Mar 20, 2025

This adds support for starting a PolyScopeX-based URsim. The default version will still be the latest PolyScope 5 version.

At this moment, this does not install the External Control URCapX as we don't have a download of the built package available.

@urfeex urfeex requested a review from a team March 20, 2025 09:17
@urrsk urrsk requested a review from tsha-ur March 20, 2025 09:38

echo ""; echo "UrService is up"

# TODO: Once we have a downloadable URCapX, we can use the following code to install it
Copy link
Contributor

@domire8 domire8 Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @urfeex sorry for peeking, when is the expected release here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot give a date, but we are trying to finalize things at the moment. The version from UniversalRobots/Universal_Robots_ExternalControl_URCapX should work mostly fine at the moment, with UniversalRobots/Universal_Robots_ExternalControl_URCapX#7 being merged soon, I guess.

This has to be built manually at the moment, which is why I placed the comment in the script for now. We plan to have a CI and a released .urcapx in the repo soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure I understand. Thanks for the reply! We might try this out in the next couple of weeks 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out and works like a charm so far 👍

@urfeex urfeex requested a review from urmahp March 26, 2025 10:58
@urfeex
Copy link
Member Author

urfeex commented Mar 26, 2025

@urmahp I've done some major refactoring with more validation and tests of that validation. This should allow us to react on future changes in a more robust way that we did in the past.

Comment on lines +42 to +44
#declare -Ag POLYSCOPE_X_MAP=( ["10.7.0"]="0.12.159"
#["10.8.0"]="not.there.yet")
declare -Ag POLYSCOPE_X_MAP=( ["10.7.0"]="0.12.159" )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#declare -Ag POLYSCOPE_X_MAP=( ["10.7.0"]="0.12.159"
#["10.8.0"]="not.there.yet")
declare -Ag POLYSCOPE_X_MAP=( ["10.7.0"]="0.12.159" )
declare -Ag POLYSCOPE_X_MAP=(
["10.7.0"]="0.12.159"
["10.8.0"]="0.13.106"
)

10.8.0 is available here https://hub.docker.com/r/universalrobots/ursim_polyscopex/tags

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, this is still a beta version. I expect, there will be another version released once the final 10.8.0 is there?

Copy link

@EbbeFuglsang EbbeFuglsang Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right. So maybe it is just a 10.8.0-0😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be OK with leaving this out of this PR for now?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is fine. Maybe we can consider how we are tagging the PolyScope X ursim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants