-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make start_ursim.sh support polyscopex #294
base: master
Are you sure you want to change the base?
Conversation
|
||
echo ""; echo "UrService is up" | ||
|
||
# TODO: Once we have a downloadable URCapX, we can use the following code to install it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @urfeex sorry for peeking, when is the expected release here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot give a date, but we are trying to finalize things at the moment. The version from UniversalRobots/Universal_Robots_ExternalControl_URCapX should work mostly fine at the moment, with UniversalRobots/Universal_Robots_ExternalControl_URCapX#7 being merged soon, I guess.
This has to be built manually at the moment, which is why I placed the comment in the script for now. We plan to have a CI and a released .urcapx in the repo soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sure I understand. Thanks for the reply! We might try this out in the next couple of weeks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out and works like a charm so far 👍
@urmahp I've done some major refactoring with more validation and tests of that validation. This should allow us to react on future changes in a more robust way that we did in the past. |
#declare -Ag POLYSCOPE_X_MAP=( ["10.7.0"]="0.12.159" | ||
#["10.8.0"]="not.there.yet") | ||
declare -Ag POLYSCOPE_X_MAP=( ["10.7.0"]="0.12.159" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#declare -Ag POLYSCOPE_X_MAP=( ["10.7.0"]="0.12.159" | |
#["10.8.0"]="not.there.yet") | |
declare -Ag POLYSCOPE_X_MAP=( ["10.7.0"]="0.12.159" ) | |
declare -Ag POLYSCOPE_X_MAP=( | |
["10.7.0"]="0.12.159" | |
["10.8.0"]="0.13.106" | |
) |
10.8.0 is available here https://hub.docker.com/r/universalrobots/ursim_polyscopex/tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, this is still a beta version. I expect, there will be another version released once the final 10.8.0 is there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right. So maybe it is just a 10.8.0-0😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be OK with leaving this out of this PR for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is fine. Maybe we can consider how we are tagging the PolyScope X ursim
This adds support for starting a PolyScopeX-based URsim. The default version will still be the latest PolyScope 5 version.
At this moment, this does not install the External Control URCapX as we don't have a download of the built package available.