fix: can overwrite sdk header (#709)

Unleash · Feb 6, 2025 · 9551215 · 9551215
1 parent 165ea52
commit 9551215
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/request.ts b/src/request.ts
@@ -96,15 +96,18 @@ export const buildHeaders = ({
   if (specVersionSupported) {
     head['Unleash-Client-Spec'] = specVersionSupported;
   }
+
+  const version = details.version;
+  head['unleash-sdk'] = `unleash-client-node:${version}`;
+
   if (custom) {
     Object.assign(head, custom);
   }
   // unleash-connection-id and unleash-sdk should not be overwritten
   if (connectionId) {
     head['unleash-connection-id'] = connectionId;
   }
-  const version = details.version;
-  head['unleash-sdk'] = `unleash-client-node:${version}`;
+
   return head;
 };
 

diff --git a/src/test/repository.test.ts b/src/test/repository.test.ts
@@ -207,7 +207,6 @@ test('should request with correct custom and unleash headers', (t) =>
       storageProvider: new InMemStorageProvider(),
       headers: {
         randomKey,
-        'unleash-sdk': 'ignore',
         'unleash-connection-id': 'ignore',
       },
     });