fix: drop ts type inference for event source #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tymek
force-pushed
the
705-missing-dependency-for-typeslaunchdarkly-eventsource
branch
from
e383081 to
f6dde47
Compare
Tymek
force-pushed
the
705-missing-dependency-for-typeslaunchdarkly-eventsource
branch
from
f6dde47 to
cdc379e
Compare
kwasniew
reviewed
Feb 4, 2025
| @@ -97,7 +97,7 @@ export default class Metrics extends EventEmitter { | |||
|
|
|||
| private url: string; | |||
|
|
|||
| private timer: NodeJS.Timer | undefined; | |||
There was a problem hiding this comment.
how did you find that this needs to change?
There was a problem hiding this comment.
I had to update Node.js types to fix other error
../node_modules/@types/node/module.d.ts:121:13 - error TS2386: Overload signatures must all be optional or required.
121 resolve?(specified: string, parent?: string | URL): Promise<string>;
~~~~~~~
And new types where complaining about NodeJS.Timer
There was a problem hiding this comment.
BTW, we should add Node v22 to our test array.
https://nodejs.org/en/about/previous-releases
kwasniew
reviewed
Feb 4, 2025
| echo -e "import { Unleash } from 'unleash-client';\nvoid Unleash;\nconsole.log('Hello world');" > src/index.ts | ||
| ./node_modules/.bin/tsc -b tsconfig.json | ||
|
|
||
| if [ "$(node . 2>&1)" = "Hello world" ]; then |
There was a problem hiding this comment.
why do we need those checks? Isn't checking exit code from tsc to be 0 enough?
There was a problem hiding this comment.
This way we can extend tests, and check if Unleash is reporting errors.
kwasniew
reviewed
Feb 4, 2025
| @@ -5105,6 +5107,11 @@ undici-types@~5.26.4: | |||
| resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617" | |||
| integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA== | |||
|
|
|||
| undici-types@~6.19.2: | |||
There was a problem hiding this comment.
is it from the upgraded @types/node transitive deps?
kwasniew
approved these changes
Feb 4, 2025
Tymek
deleted the
705-missing-dependency-for-typeslaunchdarkly-eventsource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Closes #705
Internal ticket: issue/1-3339/node-sdk-missing-dependency-for-types