Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to enable email to admins to whitelist helpful links #728

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PThorpe92
Copy link
Member

image

with the following tooltip:
image

This Pr adds the ability for an admin to request that an email be sent to the network admin

It also adds the email form back to the New User form, but only when its an admin user being created. this is so we are able to use their email for reference in the request sent to the domain admin for whitelisting.

backend/src/handlers/server.go Show resolved Hide resolved
backend/src/handlers/server.go Outdated Show resolved Hide resolved
backend/src/handlers/server.go Outdated Show resolved Hide resolved
backend/src/handlers/server.go Outdated Show resolved Hide resolved
frontend/src/Pages/HelpfulLinksManagement.tsx Outdated Show resolved Hide resolved
frontend/src/Pages/HelpfulLinksManagement.tsx Outdated Show resolved Hide resolved
frontend/src/Components/forms/AddUserForm.tsx Outdated Show resolved Hide resolved

func newAllowlistRequest(user *models.User, link *models.HelpfulLink) *emailReq {
reqTime := time.Now().Format("2006-01-02 15:04:05")
emailStr := `A new Helpful Link has been added to the UnlockEd system by an Administrator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PThorpe92 Should the message in the emailStr match the html version?

I modified the message for grammar. Can you have it say?

An Administrator has added a new Helpful Link to the UnlockEd system and requests your review to confirm it is allow-listed for all users.

Copy link
Contributor

@jtucholski jtucholski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment on the message body and pushed one change for the helpful link layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants