Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change add student to add resident, change url length #740

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

CK-7vn
Copy link
Member

@CK-7vn CK-7vn commented Feb 13, 2025

Description of the change

This increases the allowed length of the URL for helpful_links, after some research I have found that the most common character count for URL's is between 80-100 characters long, given that the actual url is not displayed and the user explicitly names the url. In the database we limit the URL to 255 characters so the URL character limit has been updated to be 255 characters. Secondly, the "Add Students" button has been changed to "Add Residents" and in the form.

Screenshot(s)

image
image
Helpful Link URL -> Description field is the URL for character count length reference
image
image

@jtucholski jtucholski self-requested a review February 14, 2025 17:22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CK-7vn Did you mean to make changes to this file? It re-introduces the problem with clicking on Edit User, pressing Esc, and then clicking a different Edit User but seeing data from the first click.

See issue #638

Copy link
Contributor

@jtucholski jtucholski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a question on this with regards to the EditUserForm. Rest of the code looks fine.

@carddev81 carddev81 self-requested a review February 14, 2025 21:06
Copy link
Contributor

@carddev81 carddev81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested great!

@carddev81 carddev81 merged commit 1689d19 into UnlockedLabs:main Feb 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update button on Residents Page Knowledge Center > Increase Character Limit in Add New Link Modal
3 participants