-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PlantSimEngine compatibilities #56
Conversation
As requested in VEZY#55
Hey @bspanoghe, thanks for the PR! Unfortunately, the tests are broken. This comes from:
Are you in a rush for this PR? Because I have little time to work on it right now unfortunately. The plan is to first make a release of PlantGeom (I have to document the new things first), then we can update the versions of all packages in this one, update the doc, update the tests and voilà! |
Note that the compat entry to PlantSimEngine, MultiScaleTreeGraph and PlantGeom will be set to the latest ones because they have breaking changes. |
Hi @VEZY, I am in no rush for the PR! I was hoping to have the package ready by JuliaCon, but I can just switch out the example plant structure for one that doesn't trigger the MTG bugs if need be. Thanks for you consideration! |
One step closer to a release of PlantBiophysics: I made a release of PlantGeom. |
Hey @bspanoghe, I finally found time to merge. I'll release it as soon as the tests on the main branch are complete. |
Thanks for keeping me updated! |
As requested in #55