Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlantSimEngine compatibilities #56

Merged
merged 10 commits into from
Jun 25, 2024
Merged

Add PlantSimEngine compatibilities #56

merged 10 commits into from
Jun 25, 2024

Conversation

bspanoghe
Copy link
Contributor

As requested in #55

@VEZY
Copy link
Owner

VEZY commented Jun 4, 2024

Hey @bspanoghe, thanks for the PR! Unfortunately, the tests are broken. This comes from:

  • changes in the way we make multiscale simulations in PlantSimEngine
  • changes in MultiScaleTreeGraph that handle the node attributes and MTG (symbols, scales...) differently
  • changes in PlantGeom that has a lot of improvements compared to the one used in the tests.

Are you in a rush for this PR? Because I have little time to work on it right now unfortunately. The plan is to first make a release of PlantGeom (I have to document the new things first), then we can update the versions of all packages in this one, update the doc, update the tests and voilà!

@VEZY
Copy link
Owner

VEZY commented Jun 4, 2024

Note that the compat entry to PlantSimEngine, MultiScaleTreeGraph and PlantGeom will be set to the latest ones because they have breaking changes.

@bspanoghe
Copy link
Contributor Author

Hi @VEZY, I am in no rush for the PR! I was hoping to have the package ready by JuliaCon, but I can just switch out the example plant structure for one that doesn't trigger the MTG bugs if need be. Thanks for you consideration!

@VEZY
Copy link
Owner

VEZY commented Jun 13, 2024

One step closer to a release of PlantBiophysics: I made a release of PlantGeom.

@VEZY VEZY merged commit c7a3be1 into VEZY:master Jun 25, 2024
7 checks passed
@VEZY
Copy link
Owner

VEZY commented Jun 25, 2024

Hey @bspanoghe, I finally found time to merge. I'll release it as soon as the tests on the main branch are complete.

@bspanoghe
Copy link
Contributor Author

Thanks for keeping me updated!

@bspanoghe bspanoghe deleted the compat-bump branch June 26, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants