Arrays support in type solver #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed jagged array rendering - Fixed safeContextWrite checking - Fixed array variance according to its element type
MchKosticyn
reviewed
Mar 8, 2024
VSharp.SILI.Core/TypeSolverUtils.fs
Outdated
| @@ -770,7 +802,7 @@ and genericCandidate private ( | |||
| if success then Some constraints | |||
| else None | |||
| else | |||
| success <- List.isEmpty sbtInterfaces | |||
| success <- success && List.isEmpty sbtInterfaces | |||
There was a problem hiding this comment.
В остальных местах не нужно, ибо там if success then, то есть success && ничего не сделает
There was a problem hiding this comment.
Это больше оптимизация эффективности, ничего семантически не изменится
VSharp.SILI.Core/TypeSolverUtils.fs
Outdated
Comment on lines
920
to
1104
| publicBuiltIn : seq<candidate> | ||
| publicUser : seq<candidate> | ||
| privateUser : seq<candidate> | ||
| rest : seq<candidate> | ||
| publicBuiltIn : candidate list | ||
| publicUser : candidate list | ||
| privateUser : candidate list | ||
| rest : candidate list |
MchKosticyn
reviewed
Mar 10, 2024
VSharp.SILI.Core/TypeSolverUtils.fs
Outdated
| @@ -758,7 +790,7 @@ and genericCandidate private ( | |||
| success <- propagateEqual constraints typedef equalType | |||
|
|
|||
| if typedef.IsInterface then | |||
There was a problem hiding this comment.
Вот тут можно добавить проверку, иначе будем бегать по циклам впустую
VSharp.SILI.Core/TypeSolverUtils.fs
Outdated
| @@ -770,7 +802,7 @@ and genericCandidate private ( | |||
| if success then Some constraints | |||
| else None | |||
| else | |||
| success <- List.isEmpty sbtInterfaces | |||
| success <- success && List.isEmpty sbtInterfaces | |||
There was a problem hiding this comment.
Это больше оптимизация эффективности, ничего семантически не изменится
MchKosticyn
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.