119 joss example data generator #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerkuou
force-pushed
the
119_joss_example_data_generator
branch
from
553b41c to
5b4b02b
Compare
rogerkuou
force-pushed
the
119_joss_example_data_generator
branch
from
3d4d97a to
8b737e5
Compare
rogerkuou
force-pushed
the
119_joss_example_data_generator
branch
from
3b7afb2 to
c9ff6c0
Compare
rogerkuou
force-pushed
the
119_joss_example_data_generator
branch
from
c9ff6c0 to
f6dc236
Compare
|
Hi @SarahAlidoost, when you have time, could you please review this PR? I this regarding a comment we got from JOSS review. When working on this, several other issues poped up so I fixed them in one go. |
docs/notebooks/example_dnn.ipynb
Outdated
| @@ -7,7 +7,8 @@ | |||
| "source": [ | |||
| "This notebooks demonstrate how to split data to train-test execute parallel DNN trainings.\n", | |||
| "\n", | |||
| "The example dataset `./example1_data.zarr/` can be generated using this [Jupyter Notebook](https://vegewaterdynamics.github.io/motrainer/notebooks/example_daskml/)." | |||
| "The example dataset `./example1_data.zarr/` can be generated using the following Jupyter Notebook:\n", | |||
| "- [Covert a nested DataFrame to a Dataset](../example_read_from_one_df)" | |||
There was a problem hiding this comment.
Suggested change
| "- [Covert a nested DataFrame to a Dataset](../example_read_from_one_df)" | |
| "- [Covert a nested DataFrame to a Dataset](./example_read_from_one_df.ipynb)" |
There was a problem hiding this comment.
Hi @SarahAlidoost, here I am linking to the rendered webpage rather than the Notebook itself. I find the original link works. Maybe let's keep it as it was?
There was a problem hiding this comment.
After discussion, we used the absolute links in the docs site.
Comment on lines
14
to
15
| "- [Prallely training sklearn models with dask-ml](../example_daskml)\n", | ||
| "- [Prallely training DNN with Tensorflow](../example_dnn)" |
There was a problem hiding this comment.
Suggested change
| "- [Prallely training sklearn models with dask-ml](../example_daskml)\n", | |
| "- [Prallely training DNN with Tensorflow](../example_dnn)" | |
| "- [Prallely training sklearn models with dask-ml](./example_daskml.ipynb)\n", | |
| "- [Prallely training DNN with Tensorflow](./example_dnn.ipynb)" |
docs/notebooks/example_daskml.ipynb
Outdated
| @@ -6,7 +6,8 @@ | |||
| "source": [ | |||
| "This notebooks demonstrate how to execute parallel machine learning training using [`dask-ml`](https://ml.dask.org/) and motrainer.\n", | |||
| "\n", | |||
| "The example dataset `./example1_data.zarr/` can be generated using this [Jupyter Notebook](https://vegewaterdynamics.github.io/motrainer/notebooks/example_daskml/)." | |||
| "The example dataset `./example1_data.zarr/` can be generated using the following Jupyter Notebook:\n", | |||
| "- [Covert a nested DataFrame to a Dataset](../example_read_from_one_df)" | |||
There was a problem hiding this comment.
Suggested change
| "- [Covert a nested DataFrame to a Dataset](../example_read_from_one_df)" | |
| "- [Covert a nested DataFrame to a Dataset](./example_read_from_one_df.ipynb)" |
SarahAlidoost
approved these changes
May 17, 2024
There was a problem hiding this comment.
@rogerkuou thanks, the relative links were not working. I suggested fixes. The rest of the changes look good. 👍
Co-authored-by: SarahAlidoost <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #119. Meanwhile also solve some popped up issues.
motrainer/util.py::performancesince the model graph issue has been solvedtf.keras.losses.mean_squared_errortotf.keras.losses.MeanSquaredError()to adapt to Tensorflow change