Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve defaults and add configuration options for logged headers #7

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Improve defaults and add configuration options for logged headers #7

merged 4 commits into from
Oct 24, 2019

Conversation

adiachenko
Copy link
Collaborator

@adiachenko adiachenko commented Oct 8, 2019 •
edited
Loading

Resolves #6

Addressed:

  • better default span names for HTTP tracing like VERB /path/for/route
  • ability to whitelist headers for logging (or use wildcard like * to log everything)
  • ability to mark headers as sensitive in order to hide their values

Additional improvements:

  • Automatically tag error spans using MessageLogged event

@adiachenko adiachenko self-assigned this Oct 8, 2019
@adiachenko adiachenko changed the title [WIP] Improve default span tags [WIP] Improve defaults and add ability to whitelist logged headers Oct 8, 2019
@adiachenko adiachenko changed the title [WIP] Improve defaults and add ability to whitelist logged headers [WIP] Improve defaults and add configuration options for logged headers Oct 23, 2019
@adiachenko adiachenko merged commit 3a714c2 into master Oct 24, 2019
@adiachenko adiachenko changed the title [WIP] Improve defaults and add configuration options for logged headers Improve defaults and add configuration options for logged headers Nov 29, 2019
@adiachenko adiachenko deleted the default-tags branch November 30, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adiachenko adiachenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using idiomatic zipkin tags
1 participant
@adiachenko