-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider name to provider resource #241
Add provider name to provider resource #241
Conversation
f5ea574
to
062cfee
Compare
src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiName.kt
Outdated
Show resolved
Hide resolved
062cfee
to
28b17f6
Compare
28b17f6
to
3d03e16
Compare
Signed-off-by: Julia Plewa <[email protected]>
Signed-off-by: Julia Plewa <[email protected]>
Signed-off-by: Julia Plewa <[email protected]>
Signed-off-by: Julia Plewa <[email protected]>
Signed-off-by: Julia Plewa <[email protected]>
3d03e16
to
8e97914
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wish I could delve into this more, but two things that I noticed (partially related to this PR)
isProvider
— passing this primitive argument through all the layers feels wrong to me. Maybe we should extendUsageKind
by adding anotherSubject
(Provider
) or take a step back and think of a better design altogether?PulumiName
— I think we could refactor it and its usage a bit along withNamingConfiguration
+UsageKind
abstractions
src/test/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiNameTest.kt
Show resolved
Hide resolved
src/test/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiNameTest.kt
Show resolved
Hide resolved
Both good points. I tried to address the first one, but adding this new enum value isn't as straightforward as it seems ( The task: #274 |
Task
Resolves: #228
Description
Disclaimer: for providers with complex names (such as
aws-native
), the names have the following format:AzurenativeProviderResource
. I'll try to figure out if there's an easy way to make the nameAzureNativeProviderResource
instead, but the easiest way was to ignore the capitalization of complex names.TODO
Add testsFix existing tests