Extract shared classes to a separate SDK #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplewa
changed the title
jplewa
force-pushed
the
41-extract-sdk-package-to-a-separate-module-and-release-as-a-separate-library
branch
2 times, most recently
from
b21565d
to
fe0acca
Compare
jplewa
changed the title
jplewa
commented
Aug 28, 2023
Signed-off-by: Julia Plewa <[email protected]>
jplewa
force-pushed
the
41-extract-sdk-package-to-a-separate-module-and-release-as-a-separate-library
branch
from
fe0acca
to
b5f0628
Compare
Signed-off-by: Julia Plewa <[email protected]>
myhau
reviewed
Aug 30, 2023
myhau
reviewed
Aug 30, 2023
myhau
approved these changes
Aug 30, 2023
Signed-off-by: Julia Plewa <[email protected]>
jplewa
force-pushed
the
41-extract-sdk-package-to-a-separate-module-and-release-as-a-separate-library
branch
from
4653739
to
57b0839
Compare
Signed-off-by: Julia Plewa <[email protected]>
jplewa
deleted the
41-extract-sdk-package-to-a-separate-module-and-release-as-a-separate-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Resolves: #41
Description
This PR is the first step. After manually releasing the SDK (by manually I mean through a CI job triggered through workflow dispatch), tagging it, and updating its version to SNAPSHOT again, we'll need another PR that would remove the built-in classes and replace them with a dependency (which should be quite easy to do, I already tested it out). I think there's no point in automating anything at this point, especially if we want to fix this bug before we release the article (+ I don't expect these files to change too much, so it shouldn't be too painful).