Add a workaround for nulls in non-nullable fields #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julia Plewa <[email protected]>
jplewa
force-pushed
the
402-temporary-workaround-for-unexpected-nulls
branch
from
3048fba
to
2793075
Compare
jplewa
changed the title
myhau
approved these changes
Apr 24, 2024
src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step3codegen/types/TypeGenerator.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step3codegen/types/TypeGenerator.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Julia Plewa <[email protected]>
jplewa
force-pushed
the
402-temporary-workaround-for-unexpected-nulls
branch
from
0ea1430
to
99d7509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Related to: #402
Description
This is absolutely not a fix, however no one will have the time to actually fix this any time soon and right now there is no way to use functions such as this one (we immediately get a NPE in
toKotlin). It's actually a great fear of mine that one of the libraries that I use in my demo presentations will break like this 🙈 The actual fix will presumably be to make all fields lazy and only report errors once they're touched by the user. With this workaround we will at least have a way to make a function/resource work after someone reports such a problem in one of the providers.