Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec partition nonce functionality #149

Merged
merged 15 commits into from
Mar 12, 2025
Merged

Spec partition nonce functionality #149

merged 15 commits into from
Mar 12, 2025

Conversation

gtanzer
Copy link
Collaborator

@gtanzer gtanzer commented Apr 9, 2024 •
edited by pr-preview bot
Loading

@gtanzer gtanzer mentioned this pull request Jun 10, 2024
Open
shivanigithub
shivanigithub reviewed Jun 10, 2024
View reviewed changes
domfarolino
domfarolino reviewed Jul 10, 2024
View reviewed changes
@gtanzer
Copy link
Collaborator Author

gtanzer commented Aug 19, 2024

@domfarolino I think all the comments are addressed now

@VergeA VergeA self-assigned this Nov 21, 2024
@VergeA
Copy link
Collaborator

VergeA commented Nov 21, 2024 •
edited
Loading

Hey y'all, this seems important to have for completeness of the network revocation spec, so I'm going to take it over from gtanzer.

Looks like all outstanding comments have been addressed, but wanted to request a re-review for any additional feedback. If there's additional changes necessary, I'll address them before we merge (and also resolve all the merge conflicts :) ).

@VergeA VergeA requested a review from domfarolino November 21, 2024 19:16
domfarolino
domfarolino reviewed Nov 21, 2024
View reviewed changes
@domfarolino
Copy link
Collaborator

I think most of this could use rewrapping. I think it rewraps too aggressively, avoiding all spaces in linked-to terms.

@VergeA
Copy link
Collaborator

VergeA commented Nov 22, 2024

Addressed all the outstanding comments, but still need to go back through and rewrap everything.

@VergeA
Copy link
Collaborator

VergeA commented Nov 25, 2024

Alright, this should be all rewrapped now.

domfarolino
domfarolino reviewed Nov 27, 2024
View reviewed changes
@blu25 blu25 mentioned this pull request Feb 26, 2025
Merged
@VergeA VergeA requested review from domfarolino and blu25 March 3, 2025 16:53
blu25
blu25 reviewed Mar 5, 2025
View reviewed changes
domfarolino
domfarolino reviewed Mar 10, 2025
View reviewed changes
@VergeA VergeA requested a review from domfarolino March 10, 2025 16:31
domfarolino
domfarolino approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@domfarolino domfarolino merged commit 01a8212 into master Mar 12, 2025
2 checks passed
@domfarolino domfarolino deleted the partition-nonce branch March 12, 2025 00:49
github-actions bot added a commit that referenced this pull request Mar 12, 2025
@gtanzer @github-actions
Spec partition nonce functionality and "credentialless" integration (#…
64b6189 
…149)

SHA: 01a8212
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blu25 blu25 blu25 left review comments

@VergeA VergeA VergeA left review comments

@shivanigithub shivanigithub shivanigithub left review comments

@domfarolino domfarolino domfarolino approved these changes

Assignees

@VergeA VergeA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gtanzer @VergeA @domfarolino @blu25 @shivanigithub