feat: 添加 PoolManager #114
Merged
feat: 添加 PoolManager #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| uint32 length = 0; | ||
| // 先算一下大小 | ||
| for (uint32 i = 0; i < pairs.length; i++) { | ||
| address[] memory addresses = pools[pairs[i].token0][pairs[i].token1]; |
There was a problem hiding this comment.
多定义一个 addresses 感觉有点多余，length += uint32(pools[pairs[i].token0][pairs[i].token1].length 感觉就好了。
yutingzhao1991
approved these changes
Oct 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
简单写了一下实现
需要确认的是 tick 和 feeProtocol 这两个参数从哪里拿