Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a look at demo_ASK #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Have a look at demo_ASK #2

wants to merge 3 commits into from

Conversation

cweickhmann
Copy link

Dear Warren,

I'm currently working on your eyediagram tool, extending it to use it in a lecture.
Therefore, I've added some filter features (have a look if you like, please).
Also, it's a really nice script that should be somewhat public domain. I see that you suggest BSD-style licensing in demo_data.py. The LICENSE.md on the other hand suggests otherwise...

Bests,
Christian

@WarrenWeckesser
Copy link
Owner

Thanks for the pull request! I'll try to take a look later this week.

I don't understand your comment about the license. I don't "suggest" BSD-style licensing. The license is the BSD 2-clause license (https://opensource.org/licenses/BSD-2-Clause).

@WarrenWeckesser
Copy link
Owner

Perhaps you are concerned about the boilerplate copyright notice, e.g. "# Copyright (c) 2015, Warren Weckesser. All rights reserved." Currently, I am have been the only author, and I have made the code available using the BSD 2-clause license. That's fine for distributing the existing code, but those copyright notices don't really fit when I start merging pull requests from other contributors. I'll have to think about the appropriate way to handle that, and look into how it is handled in other projects that I work on.

@cweickhmann
Copy link
Author

No worries, I guess it came across wrong. I was just confused, since the license should be in license.md and I didn't know if you'd be fine with forking it.

Anyhow. I'll add some additions and would like to use it as tutorial material for a lecture.

Bests

---- Warren Weckesser wrote ----

Perhaps you are concerned about the boilerplate copyright notice, e.g. "# Copyright (c) 2015, Warren Weckesser. All rights reserved." Currently, I am have been the only author, and I have made the code available using the BSD 2-clause license. That's fine for distributing the existing code, but those copyright notices don't really fit when I start merging pull requests from other contributors. I'll have to think about the appropriate way to handle that, and look into how it is handled in other projects that I work on.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants