Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Currently Released Plug-in section #107

Closed
wants to merge 0 commits into from

Conversation

mhmohona
Copy link
Contributor

Explanation

Update Currently Released Plug-ins section - added description in table and updated link for WASI-NN with TensorFlow-Lite backend.

Reopening PR #96 for passing DOC test

Related issue

#85

What type of PR is this -

/kind documentation

Proposed Changes

Copy link
Collaborator

alabulei1 commented Jun 13, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall, the GitHub Pull Request "update Currently Released Plug-in section" is a minor update to the intro.md file in WasmEdge. The patch has added additional information to the table listing the Currently Released Plug-ins, such as Rust Crate names, brief descriptions, and additional build steps. Current limitations of some of the plug-ins have also been highlighted with plans for future expansion. The only change on top of this is the correction of a typo and the addition of a new column for plug-in descriptions. There seem to be no major issues or errors that can be identified. However, it is crucial to verify the accuracy and validity of the information in the new description column to ensure that it aligns with the plug-ins released with WasmEdge.

Details

Commit 7680ea31f88063940e38721f2619002b3fe0caf3

Key changes:

  • The table listing the Currently Released Plug-ins has been updated with additional information such as the Rust Crate name, a brief description, and additional build steps.
  • The current limitations of some plug-ins have been highlighted along with plans to expand support in the future.

Potential problems:

  • None identified.

Commit 212af62c992a124c7b01e76d2b693acedec2e438

Key changes:

  • A typo in the "Currently Released Plug-in" section of the intro.md file has been fixed.
  • The table now includes a new column for plug-in descriptions.

Potential problems:

  • There appear to be no major problems with this patch.
  • However, the reviewer should verify the accuracy of the information in the new description column and ensure that it matches the plug-ins being released with WasmEdge.

@adithyaakrishna
Copy link
Contributor

@mhmohona Lint and Build CI are failing here

@mhmohona
Copy link
Contributor Author

@adithyaakrishna yes, its the same error I am getting all my PRs. I am unable to fix it. :3

@adithyaakrishna
Copy link
Contributor

@mhmohona There seems to be linting issues in many files which were not changed, I have created a PR #109 to fix the CI and linting issues :)

@alabulei1
Copy link
Collaborator

Hi @mhmohona

Sorry for my delay. The CI didn't pass. Please fix them. After that, I will merge your PR.

@mhmohona mhmohona closed this Jul 6, 2023
@mhmohona mhmohona force-pushed the current-plugin branch 2 times, most recently from 212af62 to 7bd9080 Compare July 6, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants