-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WasmEdge Style Guide #198
Conversation
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the patches reviewed in this Pull Request seem to be straightforward additions and improvements to the documentation. There are no significant issues or errors identified in any of the patches. The changes include the addition of a new FAQ page, the inclusion of a style guide, hyperlink additions and revisions, and minor wording changes. The patches aim to enhance the clarity, accuracy, and usability of the documentation for users. The most important findings include the addition of a style guide, which will help maintain consistency in coding and documentation practices. The inclusion of hyperlinks to external resources and the revision of sentences for clarity further improve the quality of the FAQ page. However, there are a few minor suggestions for improvement. Firstly, in one of the patches, the In summary, the changes made in this Pull Request overall enhance the documentation and provide valuable resources for users. With some minor improvements and corrections, these patches can be merged into the codebase without any major issues. DetailsCommit 6a5c4a884bae8bb4e4587aca8bbe3bdb44d1e2c3Key changes:
Potential problems:
Commit 8d2036363f8188b6f2d46b53cb5d1754ab375db1Key changes:
Potential problems:
Overall, the changes look good. The addition of a style guide for documentation and coding will help ensure consistency and improve the quality of the project's code and documentation. Commit 919948ef1d383f839cbfc7c0d8ee537490a277e8Key changes in the patch:
Potential problems:
Overall, the changes made in this patch improve the FAQ page by adding relevant hyperlinks to external resources. The revisions to the sentences also enhance the clarity of the content. Commit a9ee642acc2db71944cc6311452bf99c0d4800c1Key changes:
Potential problems:
Overall, the changes seem to be improvements to the FAQ page, providing more accurate information and additional resources for users. Commit d514133d59b37a2816065bd273762b18e3758f7eThe key change in this patch is a fix to a hyperlink in the file Potential problems with this patch are:
Overall, the changes in this patch appear to be straightforward and should not introduce any significant problems. Commit 7cbf126a9ea0fe3ddce20f281cafcddff4bcd7d2Key changes:
Potential problems:
Commit 79fe907884ba4a71f575c5275f0bc5ffb16f4d3aKey changes:
Potential problems:
Suggested improvement: Commit c4e3910c110325667600d9ba995930fe1e71e677Key Changes:
Potential Problems:
Overall, this patch seems to be straightforward and doesn't introduce any new issues. It can be considered for merging into the codebase. Commit 09bfb4bd2bd5e27045d6254b20c687c8c061eaefKey changes:
Potential problems:
Overall, this patch seems fine and can be merged without any issues. Commit e83f6f79efdb1d03c2e263ef8dad86ab451319b6Key changes:
Potential problems:
|
docs/develop/getting-started/faq.md
Outdated
|
||
## 2. Can WasmEdge support model training? | ||
|
||
Currently, WasmEdge supports model inference. It uses the WASI-NN API to make predictions using pre-trained models. However, model training is not yet supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link an article for AI/LLM inference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide the link of that article? I am confused which one should i add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/develop/getting-started/faq.md
Outdated
|
||
## 6. Can WasmEdge support Tensorflow as its inference backend using WASI-NN? | ||
|
||
Yes, WasmEdge can use Tensorflow as its inference backend through the WASI-NN API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a link for tensorflow inference
docs/develop/getting-started/faq.md
Outdated
|
||
## 7. How to read a host file in WasmEdge runtime? | ||
|
||
WasmEdge provides the WASI (WebAssembly System Interface) API for interacting with the host system, including file operations. You can use the WASI API to open and read files from the host system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link a doc for this function.
docs/develop/getting-started/faq.md
Outdated
|
||
WasmEdge provides the WASI (WebAssembly System Interface) API for interacting with the host system, including file operations. You can use the WASI API to open and read files from the host system. | ||
|
||
## 8. Does WasmEdge only support one backend at the same time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by backend?
Hi @mhmohona Please check out my comments. Thanks. BTW, how did you find these issues? |
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
@alabulei1 so here are the source, I had these questions while writing the plugin doc. ALso i went through the discussion to find the general questions about plugin. |
Explanation
This PR introduces a new file,
STYLE_GUIDE.md
, to the WasmEdge repository. This file contains two style guides: one for documentation and one for coding.Related issue
#85
What type of PR is this
/kind documentation
Proposed Changes