-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin information #200
Conversation
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the patch addresses a broken hyperlink in the ebpf.md file but introduces potential issues with inconsistency in the Chinese translation and trailing whitespace in some files. Additionally, the process.md file lacks instructions on how to install the WasmEdge-Process plugin. These issues should be addressed before merging the patch. DetailsCommit 6a5c4a884bae8bb4e4587aca8bbe3bdb44d1e2c3Key Changes:
Potential Problems:
Overall, this patch adds a new FAQ page to the project, which improves the documentation and provides answers to common questions about WasmEdge. The patch seems to be well-implemented and does not introduce any problems. Commit 9b1027f2b4cf2d2c846106a7538744e00de7a954Key Changes:
Potential Problems:
Overall, the patch adds useful documentation for the new plugins, but it could benefit from clarifications and additional information on certain steps. Commit de9ceb8b9239ebe72b143ebacd4fcf5b73028f4bKey changes:
Potential problems:
Overall, the changes provide more comprehensive documentation for the plugins and improve the user experience by providing detailed instructions for building and using them. Commit 0204599191b12fd6a81343120a27f4b03503826eKey changes in the patch:
Potential problems:
Overall, the changes in the patch seem to improve the documentation by adding links to the GitHub repositories for the plugins. The deletions of the FAQ files need to be reviewed for potential issues. Commit b2fa3538cd000fab6c43200e96b8318872a90c90Key changes:
Potential problems:
|
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
@@ -4,7 +4,101 @@ sidebar_position: 7 | |||
|
|||
# Build with eBPF Plug-in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask where is the source for this doc?
@@ -2,9 +2,71 @@ | |||
sidebar_position: 8 | |||
--- | |||
|
|||
# Build with Rusttls Plugin | |||
# Build with Rusttls Plug-in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask where is the source for this doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This readme file - https://github.com/WasmEdge/WasmEdge/blob/master/plugins/wasm_bpf/README.md
Nice catch! Thanks for the PR. I have left some comments. Please take a look. |
Explanation
Updated existing plugin documentation.
Related issue
#85
What type of PR is this
/kind documentation
Proposed Changes