Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bossmod triggers show timers regardless of bossmod settings #5706

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrbuds
Copy link
Contributor

@mrbuds mrbuds commented Feb 28, 2025

This make bigwigs, dbm (still active on classic), and bossmod triggers show timers regardless of bossmod bars settings

This is accomplished for BigWigs by using events BigWigs_Timer and BigWigs_CooldownTimer instead of BigWigs_StartBar
And for DBM by using DBM_TimerBegin instead of DBM_TimerStart

A new option allows to filter depending on the state of the bar in bossmod settings

Change in DBM: DeadlyBossMods/DeadlyBossMods@3bf425b
Change in BigWigs: BigWigsMods/BigWigs@3d6a290

Thanks @Justw8 and @MysticalOS

@mrbuds
Copy link
Contributor Author

mrbuds commented Feb 28, 2025

@Justw8 could you review the change?

@Justw8
Copy link
Contributor

Justw8 commented Feb 28, 2025

Tested it and it works nicely, we also did an update to the events to streamline it a bit from BW's end:

BigWigsMods/BigWigs@3d6a290

BigWigs_Timer and BigWigs_CooldownTimer are merged into 1 BigWigs_Timer.
We also initially forgot that BigWigs_CastTimer and BigWigs_TargetTimer will also need to be added.

@mrbuds mrbuds added the 👩‍🔬 Work in Progress This pull request is still being actively developed and shouldn't be merged. label Feb 28, 2025
…ttings anymore, add an option to still filter matching add settings
@mrbuds mrbuds changed the title BigWigs show timers regardless of bossmod settings Bossmod triggers show timers regardless of bossmod settings Mar 1, 2025
@mrbuds mrbuds added ⏱ Awaiting Review This pull request needs to be reviewed. and removed 👩‍🔬 Work in Progress This pull request is still being actively developed and shouldn't be merged. labels Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Review This pull request needs to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants