Update Client.php #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add more options to getShipping methods
villermen
requested changes
Dec 19, 2024
Comment on lines
+89
to
+91
| ?int $from_postal_code =null, | ||
| ?int $to_postal_code =null, | ||
| ?string $to_country =null, |
There was a problem hiding this comment.
I know it would be better to sync up the naming with Sendcloud's, but consistency with existing code is more important in this case. Let's rename these to use lowerCamelCase like the other arguments!
| ?int $from_postal_code =null, | ||
| ?int $to_postal_code =null, | ||
| ?string $to_country =null, | ||
|
|
There was a problem hiding this comment.
Empty line:
Suggested change
And: To bring this fully in line with the documentation all that's needed still is the is_return boolean argument. Let's add that while we're at it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more options to getShipping methods according to the Sendcloud documentation