10896 Duplicate component shortcut #12320
Conversation
gersona
force-pushed
the
10896_duplicate_component
branch
from
4cfb302
to
3b60881
Compare
gersona
force-pushed
the
10896_duplicate_component
branch
from
3b60881
to
ad3a863
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12320 +/- ##
===========================================
+ Coverage 24.20% 91.15% +66.94%
===========================================
Files 589 590 +1
Lines 60190 60216 +26
Branches 9530 9535 +5
===========================================
+ Hits 14569 54887 +40318
+ Misses 45487 3687 -41800
- Partials 134 1642 +1508
|
| @@ -628,6 +629,7 @@ class Component(models.Model, PathMixin, CacheKeyMixin, ComponentCategoryMixin): | |||
| "please consult the documentation for more details." | |||
| ), | |||
| validators=[validate_render_commit], | |||
| blank=True, | |||
There was a problem hiding this comment.
These should not be blank, we don't want to generate blank commit messages.
| "delete_message": forms.HiddenInput(), | ||
| "merge_message": forms.HiddenInput(), | ||
| "addon_message": forms.HiddenInput(), | ||
| "pull_message": forms.HiddenInput(), |
There was a problem hiding this comment.
Maybe just include an additional field like duplicate_component and apply content from it instead of adding plenty of hidden inputs?
|
@coderabbitai review |
Actions performedReview triggered.
|
WalkthroughThe changes introduce a new feature that allows users to duplicate components directly from the menu, enhancing usability. This functionality includes modifications to forms and models to support additional fields related to component duplication. The updates also involve improvements to tests and views to ensure proper functionality and validation of the new duplication feature. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- docs/changes.rst (1 hunks)
- weblate/templates/component.html (1 hunks)
- weblate/trans/forms.py (1 hunks)
- weblate/trans/migrations/0024_alter_component_add_message_and_more.py (1 hunks)
- weblate/trans/models/component.py (7 hunks)
- weblate/trans/tests/test_create.py (2 hunks)
- weblate/trans/tests/test_reports.py (2 hunks)
- weblate/trans/tests/utils.py (2 hunks)
- weblate/trans/views/create.py (4 hunks)
Additional comments not posted (16)
weblate/trans/migrations/0024_alter_component_add_message_and_more.py (1)
12-100: LGTM!The migration class and field alterations are correctly implemented. The changes align with the PR objectives of improving the component duplication process and ensuring that essential settings are carried over to the new component.
The default values, help text, and validators provide useful information and ensure the correct rendering of commit messages and add-on messages.
The code changes are approved.
weblate/templates/component.html (1)
101-101: LGTM!The code changes look good:
- The new list item is placed appropriately within the "Manage" dropdown menu.
- Using the current component's ID as a query parameter is an effective way to pre-fill the new component form.
- Wrapping the link text in a translation tag ensures proper localization support.
Great job!
weblate/trans/tests/test_reports.py (2)
401-403: LGTM!The code changes are approved. The new
setup_categorymethod simplifies the category creation process by directly assigning the category toself.component.category.
405-406: LGTM!The code changes are approved.
weblate/trans/tests/utils.py (1)
169-173: LGTM!The new
create_categorymethod looks good:
- It enhances the test suite by allowing the creation of test categories associated with projects.
- The method implementation is correct and follows the existing coding style and conventions.
- The import statement is updated to include the
Categorymodel.The code changes are approved.
weblate/trans/tests/test_create.py (4)
188-191: LGTM!The code changes are approved.
199-202: LGTM!The code changes are approved.
206-226: LGTM!The code changes are approved. The validation logic ensures that the component's attributes are correctly reflected in the query string.
7-7: LGTM!The code changes are approved.
weblate/trans/views/create.py (4)
441-441: LGTM!The code changes are approved.
473-486: LGTM!The code changes are approved.
517-520: LGTM!The code changes are approved.
546-562: LGTM!The code changes are approved.
docs/changes.rst (1)
9-9: Documentation update looks good!The added line accurately describes the new feature to duplicate a component from the menu.
weblate/trans/forms.py (1)
1676-1683: LGTM!The code changes are approved. The new fields added to the
Metaclass ofComponentCreateFormlook good.weblate/trans/models/component.py (1)
Line range hint
618-623: The code changes look good to me.Allowing the
merge_stylefield to be blank is fine since it will fall back to the default merge style configured in the settings.
Proposed changes
Managemenu in component details pageagreement", "merge_style", "commit_message", "add_message", "delete_message", "merge_message", "addon_message", "pull_message",Checklist
Other information
fixes #10896
Summary by CodeRabbit
New Features
Improvements
Tests