1st pass at FirmwareUpdater class. #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CartBlanche
force-pushed
the
dominique-FirmwareUpdater
branch
from
abbfc22 to
1301a50
Compare
CartBlanche
force-pushed
the
dominique-FirmwareUpdater
branch
from
3dd5b5f to
fb34ab4
Compare
adrianstevens
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key changes are to allow a serial number to be passed to the Meadow.CLI command and also DFU.
If no serial number is passed in, it behave exactly as it does now. The serial number will be required if customer want to automate flashing multiple devices themselves or when using the Provisionator.
I have tested this in Meadow.CLI with
All worked as before. I also did a Diff between the new FirmwareUpdater class and the revised FirmwareWriteCommand and other than variable case, the code logic is identical. But probably worth having another pair of eyes on it, to be sure.