Update main for v2.0.x #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fix for reading large files. bug fix for no local file name
fix id parameter in generated provisioning command
Remove Themes from Serilog output, so it works in both light and dark…
On some systems where the ILLinker fails to trim, the CLI trim command was hanging. This was caused because stderror was redirected but we never began reading from it. We can't just `ReadToEndAsync()` on stderror because then we get a hang because of stdout. So in order to work around this, use the `OutputDataReceived` and `ErrorDataReceived` functions to reading, and used `BeginErrorReadLine()` and `BeginOutputReadLine()` to execute reading of the buffers. While this fixed the hang, it immediately claimed that trimming was successful even though the process failed with a non-zero exit code. There were two reasons for this: 1. Any exception in `ILLinker.RunILLink()` gets read by `MeadowLinker.TrimMeadowApp()`'s catch statement and then disregarded, and no error code or anything else bubbles up 2. The `_logger?.LogError()` call doesn't execute because `_logger` is null, thus no output is ever seen (anywhere in the app really). So to fix these two issues I made `MeadowLinker.TrimMeadowApp()` bubble up the exception. This not only allows us to exit the cli for the IL Link failure (and not consider it a success), but it also shows the user ILLink output so they can diagnose the failure.
Fix trim hanging and incorrect status results.
Validate firmware before running or trimming + minor cleanup
Updated cloud package command to include non-assembly files + cleanup
Refactor nuget references
Add telemetry support
dfu uitl sends data to logger
Trim assemeblies / path fix
Add subfolder reading, writing, deleting and deployment
Fix file and folder sanitization for file-related commands
fix for CLIv1/Extension bug
* Do not turn off 'aggressive' prematurely, before the Meadow is known to re-connect.
Debug connection
…s a new line at the end.
Add support for Bluetooth MAC address.
Update Newtonsoft.Json
Remove CLI v1 code. remove old scripts, move CLI v2 to source folder
support device config read and write
Fix path and YamlDotNet References.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.